http2 headers #330
Merged
http2 headers #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Aug 19, 2021
graebm
reviewed
Sep 30, 2021
include/aws/http/request_response.h
Outdated
| * TODO: (Maybe more, connection-specific header will be removed, etc...) | ||
| */ | ||
| AWS_HTTP_API | ||
| struct aws_http_message *aws_http2_message_new_from_http1(struct aws_http_message *http1_msg); |
Contributor
There was a problem hiding this comment.
until we have reference counting on input-streams, this is dangerous
it's ok if you make this private
OR JUST ADD REFERENCE COUNTING TO INPUT_STREAMS!!! WOOO!
This reverts commit 7b0012b.
graebm
reviewed
Oct 20, 2021
graebm
reviewed
Oct 20, 2021
graebm
reviewed
Oct 20, 2021
graebm
reviewed
Oct 20, 2021
graebm
reviewed
Oct 20, 2021
graebm
reviewed
Oct 20, 2021
graebm
reviewed
Oct 20, 2021
graebm
reviewed
Oct 20, 2021
graebm
reviewed
Oct 20, 2021
graebm
approved these changes
Oct 27, 2021
source/request_response.c
Outdated
|
|
||
| int aws_http_headers_add_header(struct aws_http_headers *headers, const struct aws_http_header *header) { | ||
| /* Add pesudo headers to the front and not checking any violation until we send the header to the wire */ | ||
| bool pesudo = aws_strutil_is_http_pseudo_header_name(header->name); |
source/request_response.c
Outdated
| if (pesudo && aws_http_headers_count(headers)) { | ||
| struct aws_http_header last_header; | ||
| AWS_ZERO_STRUCT(last_header); | ||
| if (aws_http_headers_get_index(headers, aws_http_headers_count(headers) - 1, &last_header)) { |
Contributor
There was a problem hiding this comment.
trivial: don't need to check this error. it can only fail if the range is wrong, and you just checked the range
| } | ||
| front = !aws_strutil_is_http_pseudo_header_name(last_header.name); | ||
| } | ||
| return s_http_headers_add_header_impl(headers, header, front); |
Contributor
There was a problem hiding this comment.
i think this is weird but ughghghgh whatever
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP2 headers
addwill push the pseudo header to the front of the list when needed (the last header is NOT pseudo header)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.