Skip to content

Misc cleanup of aws-c-http #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 9, 2019
Merged

Misc cleanup of aws-c-http #30

merged 6 commits into from
Apr 9, 2019

Conversation

@graebm
Copy link
Contributor

@graebm graebm commented Apr 8, 2019

  • Remove "TODO" comments that exist as tasks on our planning board.
  • Write unit tests to address some TODO comments.
  • Check for overflow when summing numbers.
  • Don't log contents of bad data at the ERROR level, log it at DEBUG. This is to avoid log injection attacks.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@graebm graebm requested a review from a team April 8, 2019 19:07
justinboswell
justinboswell approved these changes Apr 9, 2019
View reviewed changes
@graebm graebm merged commit eeb0597 into master Apr 9, 2019
@graebm graebm deleted the todone branch April 9, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@justinboswell justinboswell justinboswell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@graebm @justinboswell