Websocket close timeout #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinboswell
approved these changes
Aug 10, 2020
Contributor
justinboswell
left a comment
justinboswell
left a comment
There was a problem hiding this comment.
LGTM, I would want @graebm 's opinion though
graebm
approved these changes
Aug 10, 2020
|
|
||
| if (!websocket->thread_data.is_waiting_for_write_completion) { | ||
| /* Not waiting for write to complete, which means the CLOSE frame has sent, just do nothing */ | ||
| return; |
Contributor
There was a problem hiding this comment.
if (!websocket->thread_data.is_waiting_for_write_completion)
if (!websocket->is_shutting_down_and_waiting_for_close_frame_to_be_written)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Cancel the CLOSE frame when it is blocked
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.