Bump AWS_EVENT_STREAM_MAX_MESSAGE_SIZE to 256MB #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMusatkin
approved these changes
Feb 10, 2025
graebm
added a commit
that referenced
this pull request
Feb 13, 2025
*Issue:* The [previous PR](#122) increased MAX_MESSAGE_SIZE from 16MiB -> 256MiB because some services were bumping into this limit. This is lower that its actual technical max of INT32_MAX (2GiB+), but it seemed like there should still have **some** reasonable value. MAX_HEADERS_SIZE is a similar constant, set lower than its actual technical limit of INT32_MAX (2GiB+), and was not adjusted in the previous PR *Description of changes:* * Set MAX_HEADERS_SIZE equal to MAX_MESSAGE_SIZE * Yes, it's silly for a message to be 100% headers, but 🤷♀️ * Document how many bytes are used to encode these things, so we know which constants can be bumped higher or not. * Add image and text to Readme (copied [Transcribe docs](https://docs.aws.amazon.com/transcribe/latest/dg/streaming-setting-up.html)) the explains the encoding (I always need to look this up myself) * Remove ~AWS_EVENT_STREAM_HEADER_STATIC_VALUE_LEN_MAX~, a value that is only used once internally, and whose existence can only serve to confuse users of this library * Add AWS_EVENT_STREAM_HEADER_VALUE_LEN_MAX, because that is an actual technical limit a user might be interested in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We will bump the limit to 256 MB, which is a reasonably high limit.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.