Split athena-jdbc into three separated connectors #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmran
reviewed
Jan 24, 2022
janmran
reviewed
Jan 24, 2022
janmran
reviewed
Jan 24, 2022
janmran
reviewed
Jan 24, 2022
janmran
reviewed
Jan 24, 2022
.../src/test/java/com/amazonaws/athena/connectors/postgresql/PostGreSqlMetadataHandlerTest.java
Outdated
Show resolved
Hide resolved
janmran
reviewed
Jan 24, 2022
...in/java/com/amazonaws/athena/connectors/jdbc/connection/DatabaseConnectionConfigBuilder.java
Show resolved
Hide resolved
kparwal
changed the title
kparwal
force-pushed
the
split-jdbc
branch
2 times, most recently
from
6f587b7 to
a8f070b
Compare
janmran
reviewed
Feb 2, 2022
...dbc/src/main/java/com/amazonaws/athena/connectors/jdbc/connection/JdbcConnectionFactory.java
Show resolved
Hide resolved
janmran
reviewed
Feb 2, 2022
...sql/src/main/java/com/amazonaws/athena/connectors/postgresql/PostGreSqlCompositeHandler.java
Outdated
Show resolved
Hide resolved
janmran
reviewed
Feb 2, 2022
...esql/src/main/java/com/amazonaws/athena/connectors/postgresql/PostGreSqlMetadataHandler.java
Show resolved
Hide resolved
janmran
reviewed
Feb 2, 2022
janmran
reviewed
Feb 2, 2022
janmran
reviewed
Feb 2, 2022
janmran
reviewed
Feb 2, 2022
janmran
reviewed
Feb 3, 2022
kparwal
force-pushed
the
split-jdbc
branch
3 times, most recently
from
794502c to
1362097
Compare
Remove static database configurations in favor of connectors injecting their own factories/connection details.
Changing some constructors to fit new dependency injection paradigm.
Create multiplexers and tests for multiplexers.
burhan94
approved these changes
Feb 4, 2022
| @@ -92,7 +92,7 @@ protected JdbcMetadataHandler() | |||
|
|
|||
There was a problem hiding this comment.
Can we get rid of the constructor above? the super(null) is obfuscating metrics on the engine side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
athena-jdbcused to hold code for thepostgresql,mysql, andredshiftconnectors. This refactor splits out those three while keeping the shared generic code inathena-jdbc.A single lambda can no longer multiplex between the three supported jdbc connectors. However, new handlers with
Muxin each of the new separated connectors can still multiplex between databases of the same type (e.g.MySqlMuxCompositeHandlercan multiplex between several MySql instances, but not a postgres instance).Some TODOs:
overlapping classes definedwarningsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.