Skip to content

Begin implementing support for offline mode #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Begin implementing support for offline mode #104

merged 6 commits into from
Sep 5, 2024

Conversation

awsmadi
Copy link
Contributor

@awsmadi awsmadi commented Aug 12, 2024

Issue #, if available:

Description of changes:
Introduce support for executing ASH offline after building the container

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Introduce scripts and additional flags
@scrthq scrthq self-requested a review August 12, 2024 21:46
@awsmadi awsmadi requested a review from scrthq August 26, 2024 13:25
scrthq
scrthq previously approved these changes Aug 28, 2024
Copy link
Contributor

@scrthq scrthq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything is working, actual scan is running noticeably faster as well thanks to the dependencies being included in the built image. Excellent job, @awsmadi !!!

@awsmadi awsmadi marked this pull request as ready for review September 3, 2024 15:55
Copy link
Contributor

@scrthq scrthq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge from my perspective!

@awsmadi awsmadi merged commit c628a2d into main Sep 5, 2024
4 checks passed
@awsmadi awsmadi deleted the offline-mode branch September 5, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants