IoStats-CallBack-AAL #298
Merged
IoStats-CallBack-AAL #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhav5140
had a problem deploying
to
integration-tests
GitHub Actions
Failure
rajdchak
reviewed
Jun 25, 2025
input-stream/src/main/java/software/amazon/s3/analyticsaccelerator/S3SeekableInputStream.java
Outdated
Show resolved
Hide resolved
ahmarsuhail
reviewed
Jun 25, 2025
...ream/src/main/java/software/amazon/s3/analyticsaccelerator/S3SeekableInputStreamFactory.java
Show resolved
Hide resolved
ahmarsuhail
reviewed
Jun 25, 2025
input-stream/src/main/java/software/amazon/s3/analyticsaccelerator/io/physical/data/Block.java
Outdated
Show resolved
Hide resolved
vaibhav5140
had a problem deploying
to
integration-tests
GitHub Actions
Failure
ahmarsuhail
reviewed
Jul 1, 2025
common/src/main/java/software/amazon/s3/analyticsaccelerator/util/RequestCallback.java
Outdated
Show resolved
Hide resolved
ahmarsuhail
reviewed
Jul 1, 2025
...am/src/main/java/software/amazon/s3/analyticsaccelerator/io/physical/data/MetadataStore.java
Outdated
Show resolved
Hide resolved
ahmarsuhail
requested changes
Jul 1, 2025
There was a problem hiding this comment.
@vaibhav5140 I don't see any tests for your changes?
You will need to assert that the methods in your callback are getting called.
vaibhav5140
had a problem deploying
to
integration-tests
GitHub Actions
Failure
ahmarsuhail
previously approved these changes
Jul 1, 2025
| objectClient.headObject( | ||
| HeadRequest.builder().s3Uri(s3URI).build(), openStreamInformation))); | ||
| () -> { | ||
| CompletableFuture<ObjectMetadata> result = |
There was a problem hiding this comment.
what about updating the head request metric?
|
|
||
| @Override | ||
| public void onGetRequest() { | ||
| LOG.debug("GET request made"); |
There was a problem hiding this comment.
sorry can you move this to TRACE? just thinking logging this at debug will create a lot of noise in the benchmarking logs
vaibhav5140
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
ozkoca
pushed a commit
that referenced
this pull request
Jul 14, 2025
## Description of change <!-- Thank you for submitting a pull request!--> <!-- Please describe your contribution here. What and why? --> <!-- Please ensure your commit messages follow these [guidelines](https://chris.beams.io/posts/git-commit/). --> This PR implements a callback mechanism that allows the analytics accelerator to pass metrics back to the S3A connector, ensuring that each GET operation properly increments the STREAM_READ_ANALYTICS_GET_REQUESTS counter. This enables S3A to monitor and assert with accurate statistics. Public Jira: https://issues.apache.org/jira/browse/HADOOP-19364 Haddop S3A PR: apache/hadoop#7763 --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR implements a callback mechanism that allows the analytics accelerator to pass metrics back to the S3A connector, ensuring that each GET operation properly increments the STREAM_READ_ANALYTICS_GET_REQUESTS counter. This enables S3A to monitor and assert with accurate statistics.
Public Jira: https://issues.apache.org/jira/browse/HADOOP-19364
Haddop S3A PR: apache/hadoop#7763
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).