Update README to include instructions for pull requests. #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disa6302
reviewed
Aug 19, 2021
README.md
Outdated
| @@ -299,6 +299,10 @@ All Public APIs are documented in our [Include.h](https://github.com/awslabs/ama | |||
|
|
|||
| Refer to [related](#related) for more about WebRTC and KVS. | |||
|
|
|||
| ## Development | |||
|
|
|||
| If you would like to contribute to the development of this project, please base your pull requests off of the develop branch, and to the develop branch. Commits from develop will be merged into master periodically as a part of each release cycle. | |||
There was a problem hiding this comment.
Nit: To be clear with the branch name, let us add origin/develop or develop in code block so that it is clearly visible.
There was a problem hiding this comment.
@jdelapla can you please make this change?
disa6302
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.