Change agedFailoverTimeMultiplier config to enablePriorityLeaseAssignment #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucienlu-aws
commented
Apr 19, 2024
| @@ -87,7 +87,7 @@ public void setWorkerId(String workerId) { | |||
| @ConfigurationSettable(configurationClass = LeaseManagementConfig.class) | |||
| private long failoverTimeMillis; | |||
| @ConfigurationSettable(configurationClass = LeaseManagementConfig.class) | |||
| private int agedFailoverTimeMultiplier; | |||
| private Boolean doPriorityLeaseTaking; | |||
There was a problem hiding this comment.
After doing some testing, I found that when this value is a primitive boolean, the config isn't set properly. This applies to all other boolean configs in multilang as well. Will make another PR fixing it for other configs
| @@ -57,7 +57,7 @@ public class LeaseManagementConfig { | |||
| public static final long DEFAULT_COMPLETED_LEASE_CLEANUP_INTERVAL_MILLIS = Duration.ofMinutes(5).toMillis(); | |||
| public static final long DEFAULT_GARBAGE_LEASE_CLEANUP_INTERVAL_MILLIS = Duration.ofMinutes(30).toMillis(); | |||
| public static final long DEFAULT_PERIODIC_SHARD_SYNC_INTERVAL_MILLIS = 2 * 60 * 1000L; | |||
| public static final int DEFAULT_AGED_FAILOVER_TIME_MULTIPLIER = 3; | |||
| public static final boolean DEFAULT_DO_PRIORITY_LEASE_TAKING = true; | |||
There was a problem hiding this comment.
nit: maybe consider renaming to enable_priority_lease_assignment ?
There was a problem hiding this comment.
I like that naming better, updated
| * (agedFailoverTimeMultiplier * failoverTimeMillis) are taken with priority, disregarding the target | ||
| * but obeying the maximum limit per worker. | ||
| * Whether workers should take very expired leases at priority. A very expired lease is when a worker does not | ||
| * renew its lease in 3 * {@link LeaseManagementConfig#failoverTimeMillis}. Very expired leases will be taken at |
There was a problem hiding this comment.
Can you also mentioned newly created leases due to shard mutation that are not assigned to any worker are also considered very-expired ?
| final List<Lease> allLeases = new ArrayList<>(); | ||
| allLeases.add(createLease("foo", "2", MOCK_CURRENT_TIME)); | ||
| allLeases.add(createLease("bar", "3", veryOldThreshold - 1)); | ||
| allLeases.add(createLease("baz", "4", veryOldThreshold + 1)); |
There was a problem hiding this comment.
Also add some leases not assigned to any worker?
akidambisrinivasan
approved these changes
Apr 19, 2024
akidambisrinivasan
pushed a commit
to akidambisrinivasan/amazon-kinesis-client
that referenced
this pull request
Apr 29, 2024
…slabs#1317) * Change agedFailoverTimeMultiplier config to doPriorityLeaseTaking
lucienlu-aws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Change the agedFailoverTimeMultiplier config to doPriorityLeaseTaking. This allows clients to disable the priority lease taking logic entirely if they choose
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.