Reuse 'ShardSyncTaskManager' instance for existing stream to avoid duplicate enqueue of 'ShardSyncTask' #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plicate enqueue of 'ShardSyncTask'
brendan-p-lynch
approved these changes
Mar 26, 2024
akidambisrinivasan
pushed a commit
to akidambisrinivasan/amazon-kinesis-client
that referenced
this pull request
Apr 29, 2024
…plicate enqueue of 'ShardSyncTask' (awslabs#1277) Co-authored-by: Tongqing Zhang <tqzhang@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
streamToShardSyncTaskManagerMapin Scheduler aConcurrentHashMapand pass it intoPeriodicShardSyncManagerwhen a host is elected as leaderShardSyncTaskManagerto improveShardSyncTaskPerformanceNumSkippedShardSyncTaskto track how many submissions of ShardSyncTask were skipped because of previous ongoing taskBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.