Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add packer variable files option #694

Closed

Conversation

GwonsooLee
Copy link

@GwonsooLee GwonsooLee commented Jul 13, 2021

Issue #, if available:

Description of changes:
Add packer variable file environment variables for users to specify the custom variable files for packer. Users now can only set variables dynamically by setting PACKER_VARIABLES. If users want to modify few more variables which are not listed int PACKER_VARIABLES, then it would be helpful for them to define variables in json file and specify the file name to PACKER_VAR_FILE

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cartermckinnon
Copy link
Member

Looks fine to me; if you resolve the conflict and rename this PACKER_VARIABLE_FILE, I'm on board 👍

@cartermckinnon cartermckinnon added the enhancement New feature or request label Oct 18, 2022
@cartermckinnon
Copy link
Member

This will be resolved by #1079 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants