Revert "Change cgroup driver to systemd (#521)" #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f9d2c39.
mmerkes
approved these changes
Dec 17, 2020
Contributor
|
I don't necessarily understand why a revert. A tool downstream is breaking, why should that influence what happens in the upstream? |
Contributor
|
@abeer91 Also could you please link to the ticket in eksctl that tracks this issue, so we can re-apply the change once the downstream manages to fix their incompatibility? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f9d2c39.
Description of changes:
EksCtl uses a nodebootsrap process where it configures the kubelet config, but not the docker config
Before we revert this commit, we need to finalize on how we can safely update eksctl to also set these values.
https://github.com/weaveworks/eksctl/blob/1555c35b1b315ff31c062a789c5f756a6122d057/docs/current-001-node_bootstrap.md
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.