Fix AL2023 Support for iam_instance_profile #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been waiting for this feature and I'm glad someone did it! |
|
/ci build |
|
@cartermckinnon roger that! I've dispatched a workflow. 👍 |
|
@cartermckinnon the workflow that you requested has completed. 🎉
|
cartermckinnon
approved these changes
Sep 23, 2024
|
@pjaudiomv thanks for the fix! |
no problem, thanks for quick review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This fixes
iam_instance_profilesupport for AL2023, which the variable was added here #1679 but never actually added to the input of builder.You can see it was added for AL2 (which I tested and works fine as well) but just missed for AL2023 https://github.com/awslabs/amazon-eks-ami/pull/1679/files#diff-c3563ab5a13c6689c9dc12566a56fa84b6d0fbe0b780c749ea4e4119e463e477R90
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
I built the image locally using
ssh_interface=session_manager iam_instance_profile=SSMAutomationPackerand was able to successfully build AL2023 over SSMSee this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.