Update instance type networking limits #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issacwww
approved these changes
Jan 25, 2023
| @@ -209,7 +218,7 @@ g5.12xlarge 737 | |||
| g5.16xlarge 234 | |||
| g5.24xlarge 737 | |||
| g5.2xlarge 58 | |||
| g5.48xlarge 737 | |||
| g5.48xlarge 345 | |||
There was a problem hiding this comment.
I have no idea, I just ran the VPC CNI script: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/scripts/gen_vpc_ip_limits.go and saw that it pulled a new limit here
There was a problem hiding this comment.
based on the change in pkg/awsutils/vpc_ip_resource_limit.go in this PR, the ENILimit for g5.48xlarge changed from 15 to 7, double confirmed by checking DescribeInstanceTypes API, see the response of NetworkInfo for g5.48xlarge below
"NetworkInfo": {
"NetworkPerformance": "100 Gigabit",
"MaximumNetworkInterfaces": 7,
"MaximumNetworkCards": 1,
"DefaultNetworkCardIndex": 0,
"NetworkCards": [
{
"NetworkCardIndex": 0,
"NetworkPerformance": "100 Gigabit",
"MaximumNetworkInterfaces": 7
}
],
"Ipv4AddressesPerInterface": 50,
"Ipv6AddressesPerInterface": 50,
"Ipv6Supported": true,
"EnaSupport": "required",
"EfaSupported": true,
"EfaInfo": {
"MaximumEfaInterfaces": 1
},
"EncryptionInTransitSupported": true,
"EnaSrdSupported": false
}There was a problem hiding this comment.
Ah nice, thank you for checking!
There was a problem hiding this comment.
Pretty odd that this changed, but the API doesn't lie. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Updates instance networking limits in
eni-max-pods.txt. Mirrors aws/amazon-vpc-cni-k8s#2235By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
N/A