Short-circut sandbox image fetching #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bwagner5 you got thoughts on this one? |
|
This LGTM to improve stability for edge deployments. |
vpineda1996
force-pushed
the
master
branch
2 times, most recently
from
b012a47
to
1339eda
Compare
cartermckinnon
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The commit short-circuits fetching the sandbox image from ECR whenever its present locally. This is needed to support edge device stability during disconnection.
In order to bring the kubelet back online, systemd will create a sandbox in which the kubelet will run. If connection to the AWS region is down, we won't be able to reach ECR and pulling will fail.
We don't need to call ECR to pull the image if its available locally. So this commit adds that short-circuiting.
Testing Done