Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Offline-ER to work with collate_fn #390

Merged
merged 14 commits into from
Sep 22, 2023
Merged

Refactor Offline-ER to work with collate_fn #390

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e5f0d3e
changes to Offline-ER without drop_last=True in learner
wistuba Aug 23, 2023
542c855
fix sampler
wistuba Aug 23, 2023
c23014d
update expected values
wistuba Aug 23, 2023
0f8803a
flake
wistuba Aug 23, 2023
546b8eb
flake
wistuba Aug 23, 2023
8cea500
update expected numbers and add unit test
wistuba Aug 23, 2023
0b07ac3
small code improvements
wistuba Aug 24, 2023
c233f95
Merge branch 'dev' into mw-offline-er-fix
wistuba Sep 18, 2023
8190e26
ddp compatible sampler
wistuba Sep 19, 2023
8c69db7
lint
wistuba Sep 19, 2023
40ffc88
fix small bug
wistuba Sep 19, 2023
a3bf468
add typing
wistuba Sep 19, 2023
2746391
provide better docs for batch sampler
wistuba Sep 21, 2023
615dc16
test distributed behavior
wistuba Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix small bug
  • Loading branch information
@wistuba
wistuba committed Sep 19, 2023
commit 40ffc8813fa0c177fe7988bce0b8093b8b5293b3
2 changes: 1 addition & 1 deletion src/renate/utils/pytorch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def __init__(
True,
)
self.subset_samplers.append(subset_sampler)
num_batches.append((end_idx - start_idx + 1) // batch_size)
num_batches.append((end_idx - start_idx) // batch_size)
data_start_idx = data_end_idx
self.length = (
min(num_batches)
Expand Down