This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Private key does not belong in device OTA config #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wording that one must include the **private key** into `aws_ota_codesigner_certificate.h` seems incorrect. AFAICT only the (public) certificate is needed on the device.
robhath
approved these changes
Jun 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wording that one should include the private key into
aws_ota_codesigner_certificate.his surely incorrect? AFAICT only the (public) certificate should be needed on the device.The documentation and sample code for the OTA tests also appears to confirm this:
…the
ecdsa-sha256-signer.crt.pemcertificate being very distinct from thersa-sha256-signer.key.pemprivate key. Only the former is included in the codesign configuration header which is built into the device.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.