Skip to content

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. fix sessionId in first open and session start events

How did you test these changes?
added test case for assert first open and session start event have the same sessionid

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Mar 4, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane March 4, 2024 05:44
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.49%. Comparing base (f9d9e57) to head (76e068c).
Report is 16 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #68      +/-   ##
============================================
- Coverage     87.42%   86.49%   -0.94%     
  Complexity      458      458              
============================================
  Files            42       42              
  Lines          1686     1688       +2     
  Branches        152      154       +2     
============================================
- Hits           1474     1460      -14     
- Misses          135      150      +15     
- Partials         77       78       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit f2f80fd into main Mar 4, 2024
@zxkane zxkane deleted the fix-sessionId branch March 4, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants