-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QoS - API and implemention for event callbacks #6
Commits on Apr 19, 2019
-
Every executor gets its own SIGINT guard condition (ros2#308)
* Every executor gets its own SIGINT guard condition Moves signal handling code to _rclpy_signal_handler Every executor adds a guard condition to a global list SIGINT signal handler triggers all guard conditions in global list Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * _sigint_gc robust to shutdown() called twice Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove redundant comments Comments say the same thing twice. It only needs to be said once. Remove extra comments so the same thing is not repeated. Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Split loop for readability Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * g_guard_conditions atomic variable Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Use rclutils_atomics macros Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Call original handler before losing reference to it Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * remove extra unnecessary assignment Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * g_guard_conditions is a struct on windows Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Rename action state transitions (ros2#300) * Rename action state transitions Now using active verbs as described in the design doc: http://design.ros2.org/articles/actions.html#goal-states Connects to ros2/rcl#399. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * add missing error handling and cleanup (ros2#315) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * Don't store sigint_gc address Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * remove redundant conditional Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Every executor gets its own SIGINT guard condition Moves signal handling code to _rclpy_signal_handler Every executor adds a guard condition to a global list SIGINT signal handler triggers all guard conditions in global list Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * _sigint_gc robust to shutdown() called twice Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove redundant comments Comments say the same thing twice. It only needs to be said once. Remove extra comments so the same thing is not repeated. Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Split loop for readability Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * g_guard_conditions atomic variable Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Use rclutils_atomics macros Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Call original handler before losing reference to it Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * remove extra unnecessary assignment Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * g_guard_conditions is a struct on windows Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Don't store sigint_gc address Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * remove redundant conditional Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Configuration menu - View commit details
-
Copy full SHA for afc4cd4 - Browse repository at this point
Copy the full SHA afc4cd4View commit details
Commits on Apr 24, 2019
-
enforce correct message type is passed to various API (ros2#317)
* add tests ensuring TypeError is raised Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * raise TypeError when passing invalid message types Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 4bf61f4 - Browse repository at this point
Copy the full SHA 4bf61f4View commit details -
QoS event callbacks implementation
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Emerson Knapp committedApr 24, 2019 Configuration menu - View commit details
-
Copy full SHA for 8f93099 - Browse repository at this point
Copy the full SHA 8f93099View commit details -
Using i for type instead of l, because l wasn't understanding -1
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Emerson Knapp committedApr 24, 2019 Configuration menu - View commit details
-
Copy full SHA for c8549b7 - Browse repository at this point
Copy the full SHA c8549b7View commit details -
remove incorrect conclusion, I was seeing an existing shutdown issue …
…in my test app, not in the rclpy functionality Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Emerson Knapp committedApr 24, 2019 Configuration menu - View commit details
-
Copy full SHA for e8024c2 - Browse repository at this point
Copy the full SHA e8024c2View commit details -
Address python-side review comments
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Emerson Knapp committedApr 24, 2019 Configuration menu - View commit details
-
Copy full SHA for d3bf96b - Browse repository at this point
Copy the full SHA d3bf96bView commit details -
Start addressing some of the C side feedback
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Emerson Knapp committedApr 24, 2019 Configuration menu - View commit details
-
Copy full SHA for 5ec5b77 - Browse repository at this point
Copy the full SHA 5ec5b77View commit details -
XDECREFs all in one place instead of complex deref logic
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Emerson Knapp committedApr 24, 2019 Configuration menu - View commit details
-
Copy full SHA for 8d9856d - Browse repository at this point
Copy the full SHA 8d9856dView commit details -
Fix lint, start adding unit test
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Emerson Knapp committedApr 24, 2019 Configuration menu - View commit details
-
Copy full SHA for 41854b5 - Browse repository at this point
Copy the full SHA 41854b5View commit details -
Test num_events in NumberOfEntities
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Emerson Knapp committedApr 24, 2019 Configuration menu - View commit details
-
Copy full SHA for 8dea930 - Browse repository at this point
Copy the full SHA 8dea930View commit details -
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Emerson Knapp committedApr 24, 2019 Configuration menu - View commit details
-
Copy full SHA for e61bc6c - Browse repository at this point
Copy the full SHA e61bc6cView commit details