fix(commons): rename tests subfolder to samples to avoid being deleted by tools such as node-prune

[flochaz]

Description of your changes

Current project structure is having a folder called tests under commons/src package and was hosting samples context and events to use when calling a lambda function.

Customers using tools like node-prune where having issue (#881) because the tool was deleting the folder. A fix would have been to simply use the -exclude option of this tool but here we propose to simply rename the folder to samples.

How to verify this change

1. prep the env

   npm ci --foreground-scripts
   npm run lerna-package
   cd examples/cdk
   npm ci
   npm install ../../packages/**/dist/aws-lambda-powertools-*
   npm run test

2. use node-prune

   node-prune -exclude '*.d.ts' -excludes 'assets'
   

3. test again, they should still pass

   npm run test

Related issues, RFCs

#881

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

• My changes meet the tenets criteria
• I have performed a self-review of my own code
• I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding changes to the examples
• My changes generate no new warnings
• The code coverage hasn't decreased
• I have added tests that prove my change is effective and works
• New and existing unit tests pass locally and in Github Actions
• Any dependent changes have been merged and published in downstream module
• The PR title follows the conventional commit semantics

Breaking change checklist

• I have documented the migration process
• I have added, implemented necessary warnings (if it can live side by side)

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[dreamorosi]

Is that any other way in which we can avoid including all these 50+ files in the deployment package?

Also note that there is another community PR #881 that attempts to fix this issue, we should at least address it before moving forward with this. And generally speaking, what do you think of that way of fixing it @flochaz?

[flochaz]

I think we should do both : import Utility as suggested in #881 and change name because indeed tests is a confusing name. After the question regarding the need of this samples ... I am not sure ...

[ijemmy]

Even without node-prune issue, I do agree that tests is misleading here and samples is a better name.