Skip to content

Conversation

sdangol
Copy link
Contributor

@sdangol sdangol commented Sep 22, 2025

Summary

This PR implements the feature to allow the use of prefix so that we don't need to keep repeating the same shared prefix for every route path.

Changes

Please provide a summary of what's being changed

  • Added prefix option to the RestRouterOptions in the constructor
  • Added the logic to append the prefix if present

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4513


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Sep 22, 2025
@boring-cyborg boring-cyborg bot added event-handler This item relates to the Event Handler Utility tests PRs that add or change tests labels Sep 22, 2025
@sdangol sdangol self-assigned this Sep 22, 2025
@dreamorosi
Copy link
Contributor

@sdangol please take a look at the SonarCloud findings and address them - based on a cursory read we should be able to resolve them.

Copy link

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, I tested the package in an API and it works.

Once we work on #4131 we might need to make the prefix public so it can be accessed when passing a Router to another, but we'll see once we get there.

@dreamorosi dreamorosi merged commit 8913854 into main Sep 22, 2025
37 checks passed
@dreamorosi dreamorosi deleted the feat/route-prefix branch September 22, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event-handler This item relates to the Event Handler Utility size/M PR between 30-99 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: route prefixes in HTTP Event Handler
2 participants