fix(batch): fixed the build issue with Batch processor due to missing dependencies #4498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
batch
pull-request-size
bot
added
the
size/XL
svozza
reviewed
Sep 16, 2025
|
@dreamorosi This is ready for review now |
…-lambda-typescript into fix/batch_deps
dreamorosi
reviewed
Sep 16, 2025
dreamorosi
reviewed
Sep 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build issue with the Batch processor by adding missing dependencies for Standard Schema validation support and refactoring DynamoDB stream schema validation to use consistent schemas for both OldImage and NewImage fields.
- Added
@standard-schema/specas a runtime dependency to properly support Standard Schema validation - Refactored test suite to use parameterized tests instead of deeply nested describe blocks for better maintainability
- Updated DynamoDB extended schemas to enforce the same schema for both
OldImageandNewImagefields instead of making them optional
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/batch/package.json | Added @standard-schema/spec dependency and reorganized dev dependencies |
| packages/batch/src/types.ts | Renamed type and updated to use StandardSchemaV1 instead of ZodType imports |
| packages/batch/src/parser.ts | Updated schema extension logic and made DynamoDB OldImage/NewImage validation consistent |
| packages/batch/src/BatchProcessor.ts | Added documentation example for inner schema validation |
| packages/batch/src/BasePartialBatchProcessor.ts | Updated type references to use new BatchProcessorConfig |
| packages/batch/tests/unit/parsing.test.ts | Completely refactored tests to use parameterized approach and added new test cases |
| packages/batch/tests/helpers/factories.ts | Updated DynamoDB record factory to include OldImage field |
| docs/features/batch.md | Added documentation note about DynamoDB schema behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dreamorosi
reviewed
Sep 17, 2025
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
|
dreamorosi
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the build issue with the Batch Processor due to missing dependencies with Standard Schema.
Changes
@standard-schema/specas a dependency of the Batch processor packageOldImageandNewImageand added a note in the docs about itIssue number: closes #4496
Screenshot
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.