Skip to content

improv(maintenance): Removed some unused assignments and added missing error handling #4208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025

Conversation

sdangol
Copy link
Contributor

@sdangol sdangol commented Jul 24, 2025

Summary

This PR removes some unused assignments and add error handling to the SAST findings from SonarCloud.

Changes

Please provide a summary of what's being changed

  • Removed unused variable envVarsService from packages/parameters/tests/unit/BaseProvider.test.ts
  • Added a console.error for an unhandled error in examples/snippets/parameters/testingYourCodeClientHandler.ts

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number:
Closes #4203


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Jul 24, 2025
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jul 24, 2025
@dreamorosi dreamorosi linked an issue Jul 24, 2025 that may be closed by this pull request
2 tasks
@dreamorosi dreamorosi self-requested a review July 24, 2025 14:19
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

It's ok to make PR titles more generic for this type of things, for example: improv(maintenance): removed unused assignments/code

Copy link

@svozza svozza merged commit 3f2e7fe into main Jul 24, 2025
46 checks passed
@svozza svozza deleted the improv/unused-code branch July 24, 2025 14:24
Copy link
Contributor

@aws-powertools/lambda-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS PR between 0-9 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: clean up unused code paths in Parameters
3 participants