Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add @middy/core v6 as peer dependency #3368

Merged
merged 7 commits into from
Nov 29, 2024

Conversation

anthony-nhs
Copy link
Contributor

@anthony-nhs anthony-nhs commented Nov 26, 2024

Summary

Changes

Please provide a summary of what's being changed
This PR adds @middy/core v6 as a peer dependency

You can not use @powertools-lambda-typescript and @middy/core v6

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: Closes #3367


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@anthony-nhs anthony-nhs requested review from a team as code owners November 26, 2024 09:10
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. tests PRs that add or change tests labels Nov 26, 2024
Copy link

boring-cyborg bot commented Nov 26, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Nov 26, 2024
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR.

I don't think doubling the amount of tests we run only to add Middy.js is the way to go as this doubles or more our feedback loop.

I would propose to instead use Middy.js v6 to this test only, plus one that we will add in a future PR for the Metrics utility.

This way we'll have a somewhat even distribution of tests running v4, v5, and v6 without having to repeat tests.

@pull-request-size pull-request-size bot added size/S PR between 10-29 LOC and removed size/L PRs between 100-499 LOC labels Nov 26, 2024
@anthony-nhs
Copy link
Contributor Author

ok - have changed it so that only one test is changed to use middy v6

@dreamorosi
Copy link
Contributor

Thank you for addressing the comment.

Tomorrow morning (EU time) I'll run some more in depth manual tests and familiarize myself with the changes in v6.

If there's no blocker and CI is green I'll merge this PR so that the change can land in the next release.

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience.

I ran the end to end tests on this branch and they're green.

I also looked at the v6 release notes and commit history, and there seems not to be any breaking change in the core module that would affect us.

I'm happy to merge this as-is and update the docs later.

@dreamorosi dreamorosi self-requested a review November 29, 2024 15:05
@dreamorosi dreamorosi merged commit 32baa49 into aws-powertools:main Nov 29, 2024
37 checks passed
Copy link

boring-cyborg bot commented Nov 29, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Copy link
Contributor

@aws-powertools/lambda-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/S PR between 10-29 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: add support for Middy.js 6.x
2 participants