-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add @middy/core v6 as peer dependency #3368
chore: add @middy/core v6 as peer dependency #3368
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this PR.
I don't think doubling the amount of tests we run only to add Middy.js is the way to go as this doubles or more our feedback loop.
I would propose to instead use Middy.js v6 to this test only, plus one that we will add in a future PR for the Metrics utility.
This way we'll have a somewhat even distribution of tests running v4, v5, and v6 without having to repeat tests.
…tools-lambda-typescript into fix_middy_depenedency
ok - have changed it so that only one test is changed to use middy v6 |
Thank you for addressing the comment. Tomorrow morning (EU time) I'll run some more in depth manual tests and familiarize myself with the changes in v6. If there's no blocker and CI is green I'll merge this PR so that the change can land in the next release. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience.
I ran the end to end tests on this branch and they're green.
I also looked at the v6 release notes and commit history, and there seems not to be any breaking change in the core module that would affect us.
I'm happy to merge this as-is and update the docs later.
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
@aws-powertools/lambda-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing. |
Summary
Changes
You can not use @powertools-lambda-typescript and @middy/core v6
Issue number: Closes #3367
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.