Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv(tracer): remove require in tracer provider #2557

Merged
merged 2 commits into from
May 22, 2024
Merged

improv(tracer): remove require in tracer provider #2557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9769640
improv(tracer): remove require in tracer provider
dreamorosi May 20, 2024
8f0aa3b
Merge branch 'main' into improv/tracer_require
am29d May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/tracer/src/provider/ProviderService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ import {
isHttpSubsegment,
} from './utilities.js';
import type { DiagnosticsChannel } from 'undici-types';
import http from 'node:http';
import https from 'node:https';

class ProviderService implements ProviderServiceInterface {
/**
Expand Down Expand Up @@ -70,10 +72,8 @@ class ProviderService implements ProviderServiceInterface {
}

public captureHTTPsGlobal(): void {
// eslint-disable-next-line @typescript-eslint/no-var-requires
captureHTTPsGlobal(require('http'));
// eslint-disable-next-line @typescript-eslint/no-var-requires
captureHTTPsGlobal(require('https'));
captureHTTPsGlobal(http);
captureHTTPsGlobal(https);
}

public getNamespace(): Namespace {
Expand Down