Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix update layer arn for cdk #2487

Merged
merged 1 commit into from
May 7, 2024

Conversation

am29d
Copy link
Contributor

@am29d am29d commented May 7, 2024

Summary

Changes

In this PR we remove the cdk prefix from the pseudo region check when replacing the layer version in the docs. This will fix the reported issue in #2484 .

Please provide a summary of what's being changed

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2486


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested review from a team as code owners May 7, 2024 11:22
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label May 7, 2024
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label May 7, 2024
@am29d am29d requested a review from dreamorosi May 7, 2024 11:22
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.

It stopped working because of a change I made. I changed the imports in the example to use import { Stack } from ... instead of import cdk from ... and broke this in the process.

@dreamorosi dreamorosi merged commit a1be3c0 into main May 7, 2024
17 checks passed
@dreamorosi dreamorosi deleted the docs/fix-update-layer-arn-cdk branch May 7, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: update-layer-arn should also update CDK example
2 participants