Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(jmespath): rename jmespath parsing options type #2367

Merged
merged 9 commits into from
Apr 16, 2024
Merged

refactor(jmespath): rename jmespath parsing options type #2367

merged 9 commits into from
Apr 16, 2024

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Apr 16, 2024 •
edited
Loading

Description of your changes

This PR renames the ParsingOptions type present in the JMESPath utility to JMESPathParsingOptions for clarity.

This change was made so that usages across other packages (i.e. Idempotency) are clearer on what these options refer to.

Related issues, RFCs

Issue number: #2369

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Apr 16, 2024
@dreamorosi dreamorosi requested review from a team as code owners April 16, 2024 12:47
@boring-cyborg boring-cyborg bot added the idempotency This item relates to the Idempotency Utility label Apr 16, 2024
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Apr 16, 2024
@github-actions github-actions bot added the enhancement PRs that introduce minor changes, usually to existing features label Apr 16, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Apr 16, 2024
@dreamorosi dreamorosi linked an issue Apr 16, 2024 that may be closed by this pull request
Maintenance: make ParsingOption name clearer in JMESPath utility #2369
Closed
2 tasks
Base automatically changed from feat/idempotency_custom_jmespath to main April 16, 2024 15:34
@boring-cyborg boring-cyborg bot added automation This item relates to automation documentation Improvements or additions to documentation layers Items related to the Lambda Layers pipeline dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests labels Apr 16, 2024
@pull-request-size pull-request-size bot added size/L PRs between 100-499 LOC and removed size/M PR between 30-99 LOC labels Apr 16, 2024
@dreamorosi dreamorosi force-pushed the refactor/jmespath_parsing_options branch from 792cded to 785bcad Compare April 16, 2024 15:55
@pull-request-size pull-request-size bot removed the size/L PRs between 100-499 LOC label Apr 16, 2024
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Apr 16, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

am29d
am29d approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner and more accessible now.

@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Apr 16, 2024
@dreamorosi dreamorosi merged commit 48bb9a7 into main Apr 16, 2024
13 of 15 checks passed
@dreamorosi dreamorosi deleted the refactor/jmespath_parsing_options branch April 16, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am29d am29d am29d approved these changes

Assignees

@dreamorosi dreamorosi

Labels
automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation enhancement PRs that introduce minor changes, usually to existing features idempotency This item relates to the Idempotency Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) layers Items related to the Lambda Layers pipeline size/M PR between 30-99 LOC tests PRs that add or change tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance: make ParsingOption name clearer in JMESPath utility
2 participants
@dreamorosi @am29d