Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add ContextExamples to upgrade guide #2197

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Mar 11, 2024

Description of your changes

This PR adds ContextExamples to the upgrade guide. If customers imported it from the commons package before, they'd need to create the object in their tests.

Related issues, RFCs

Issue number: closes #2195

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d self-assigned this Mar 11, 2024
@am29d am29d requested review from a team as code owners March 11, 2024 08:53
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Mar 11, 2024
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Mar 11, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update

@dreamorosi dreamorosi merged commit 9d8b903 into main Mar 11, 2024
17 checks passed
@dreamorosi dreamorosi deleted the docs/logger-fix-context-example branch March 11, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/M PR between 30-99 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Describe removing ContextExamples in the migration doc
2 participants