Skip to content

fix(docs): indentation in tutorial snippets #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

am1ru1
Copy link
Contributor

@am1ru1 am1ru1 commented Jan 31, 2022

Extra indent is triggering: "Unexpected indentation" for python from the sample docs. Fixed the indent as per previous samples.

Issue #, if available:

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


View rendered docs/tutorial/index.md

Extra indent is triggering: "Unexpected indentation" for python from the sample docs. Fixed the indent as per previous samples.
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jan 31, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 31, 2022

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.

@am1ru1 am1ru1 changed the title Docs - Extra indentation for py and sam yaml causing "Unexpected indentation" issue fix:Docs - Extra indentation for py and sam yaml causing "Unexpected indentation" issue Jan 31, 2022
@am1ru1 am1ru1 changed the title fix:Docs - Extra indentation for py and sam yaml causing "Unexpected indentation" issue fix(docs): Extra indentation for py and sam yaml causing "Unexpected indentation" issue Jan 31, 2022
@github-actions github-actions bot added the bug Something isn't working label Jan 31, 2022
@heitorlessa heitorlessa changed the title fix(docs): Extra indentation for py and sam yaml causing "Unexpected indentation" issue fix(docs): extra indentation for py and sam yaml causing "Unexpected indentation" issue Jan 31, 2022
@heitorlessa heitorlessa changed the title fix(docs): extra indentation for py and sam yaml causing "Unexpected indentation" issue fix(docs): indentation in tutorial snippets Jan 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #988 (67ccb5e) into develop (0c35e5a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #988   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          119      119           
  Lines         5335     5335           
  Branches       607      607           
========================================
  Hits          5333     5333           
  Partials         2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c35e5a...67ccb5e. Read the comment docs.

@heitorlessa
Copy link
Contributor

Hey @am1ru1 thank you SO MUCH for helping us improve the docs.

I'll rebuild it tomorrow so anyone coming for the latest will have it fixed without triggering a new release.

@heitorlessa heitorlessa merged commit 7a6e49a into aws-powertools:develop Jan 31, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 31, 2022

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@am1ru1 am1ru1 deleted the patch-1 branch January 31, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants