Skip to content

feat(event-sources): cache parsed json in data class #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 21, 2021
Prev Previous commit
chore: update tests
  • Loading branch information
Michael Brewer committed Dec 21, 2021
commit 7a623f262e3ee98b2ef1783a949bc6c820bbd424
4 changes: 2 additions & 2 deletions tests/functional/data_classes/test_amazon_mq.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def test_active_mq_event():
messages = list(event.messages)
message = messages[1]
assert message.json_data["timeout"] == 0
assert message.json_data["timeout"] == 0 # cached lookup
assert message.json_data["data"] == "CZrmf0Gw8Ov4bqLQxD4E"


def test_rabbit_mq_event():
Expand All @@ -48,7 +48,7 @@ def test_rabbit_mq_event():
assert message.data is not None
assert message.decoded_data is not None
assert message.json_data["timeout"] == 0
assert message.json_data["timeout"] == 0 # cached lookup
assert message.json_data["data"] == "CZrmf0Gw8Ov4bqLQxD4E"

assert isinstance(message, RabbitMessage)
properties = message.basic_properties
Expand Down
10 changes: 4 additions & 6 deletions tests/functional/test_data_classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def test_cognito_pre_token_generation_trigger_event():
claims_override_details.set_group_configuration_groups_to_override(expected_groups)
assert claims_override_details.group_configuration.groups_to_override == expected_groups
assert event["response"]["claimsOverrideDetails"]["groupOverrideDetails"]["groupsToOverride"] == expected_groups
claims_override_details = event.response.claims_override_details # cached lookups
claims_override_details = event.response.claims_override_details
assert claims_override_details["groupOverrideDetails"]["groupsToOverride"] == expected_groups

claims_override_details.set_group_configuration_iam_roles_to_override(["role"])
Expand Down Expand Up @@ -1056,7 +1056,7 @@ def test_base_proxy_event_json_body():
data = {"message": "Foo"}
event = BaseProxyEvent({"body": json.dumps(data)})
assert event.json_body == data
assert event.json_body == data # cached lookup
assert event.json_body["message"] == "Foo"


def test_base_proxy_event_decode_body_key_error():
Expand Down Expand Up @@ -1399,10 +1399,8 @@ def test_code_pipeline_event_decoded_data():
configuration = event.data.action_configuration.configuration
decoded_params = configuration.decoded_user_parameters
assert decoded_params == event.decoded_user_parameters
assert "VALUE" == decoded_params["KEY"]

decoded_params = configuration.decoded_user_parameters # cached lookup
assert decoded_params is not None
assert decoded_params["KEY"] == "VALUE"
assert configuration.decoded_user_parameters["KEY"] == "VALUE"

assert "my-pipeline-SourceArtifact" == event.data.input_artifacts[0].name

Expand Down