Repository navigation
test(kafka): cover custom serializer output variants - #8499
Merged
Merged
Conversation
powertools-for-aws-oss-automation
Bot
added
the
size/M
|
Referenced issues are closed or don't exist. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8499 +/- ##
===========================================
+ Coverage 96.80% 96.81% +0.01%
===========================================
Files 310 310
Lines 15594 15594
Branches 1361 1361
===========================================
+ Hits 15096 15098 +2
+ Misses 362 361 -1
+ Partials 136 135 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
svozza
approved these changes
Sep 29, 2026
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: follow-up to #8498
Summary
Changes
Adds Kafka consumer tests for custom output functions, classes, and callable objects using JSON data. Also checks that serialization without an output transform returns the original dictionary.
These cases cover both branches of
CustomDictOutputSerializer.serialize, which were flagged by Codecov after the typing fix.User experience
No runtime behavior changes.
Validation
custom_dict.py: 100% line and branch coverage.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.