feat(data-classes): support for code pipeline job event#416
Merged
heitorlessa merged 11 commits intoMay 17, 2021
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #416 +/- ##
=========================================
Coverage 99.89% 99.90%
=========================================
Files 101 102 +1
Lines 3996 4117 +121
Branches 199 204 +5
=========================================
+ Hits 3992 4113 +121
Misses 1 1
Partials 3 3
Continue to review full report at Codecov.
|
Contributor
|
Lemme know when it's ready. I think you mentioned about adding an UTF decode before finalizing the implementation |
added 4 commits
May 5, 2021 13:02
Changes: - Add more helper functions to code_pipeline_job_event
Contributor
Author
|
@heitorlessa i added some docs for this. So i think it is ready :) |
Contributor
Author
|
@jplock if you want to have a look too |
jplock
approved these changes
May 7, 2021
Contributor
Author
|
@heitorlessa anything missing here? |
Contributor
|
Hey! I’ll look it over tomorrow ;-)
I’d like to make a minor release tomorrow to get this out to everyone -
it’d be nice to have some UX examples in the PR description to make it
easier to release and make this stand out
…On Thu, 13 May 2021 at 18:46, Michael Brewer ***@***.***> wrote:
@heitorlessa <https://github.com/heitorlessa> anything missing here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#416 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBEBAEN2TUJRV23FCX3TNP67XANCNFSM44B4Z45A>
.
|
heitorlessa
approved these changes
May 17, 2021
Contributor
heitorlessa
left a comment
There was a problem hiding this comment.
Thanks a lot for working on this!
Note to self - Find a better name for this utility in 2.0, something like
event source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://github.com/awslabs/aws-lambda-powertools-python/issues/414
Description of changes:
Add support for CodePipeline Job event data class
Code example based on the docs:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.