build(pre-commit): Add pre-commit to make pr

[michaelbrewer]

Issue #, if available:

Description of changes:

pre-commit runs additional checks that make pr does not perform like trailing-whitespace

Changes:

• Add pre-commit as a target in the Makefile

Checklist

• Meet tenets criteria
• Update tests
• Update docs
• PR title follows conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov-io]

Codecov Report

Merging #368 (cce89b3) into develop (7c9a319) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #368   +/-   ##
========================================
  Coverage    99.94%   99.94%           
========================================
  Files           96       96           
  Lines         3643     3643           
  Branches       175      175           
========================================
  Hits          3641     3641           
  Partials         2        2           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9a319...cce89b3. Read the comment docs.

[heitorlessa]

Hey Michael, out of curiosity, did you run into those before?

make dev installs pre-commit hooks so they're run upon a commit.

That said, these are not run in CI and this is an improvement - is that what you intended?

Thanks ;)

[michaelbrewer]

@michaelbrewer yes I do run "make dev" and the pre-commit does run, but "make lint" does not include all of the same logic as "pre-commit".

So what happens is:

$ git add .
stage my commit
$ make pr
passes 
$ git commit -m "..."
fail due to white spaces 
$ git add .
$ git commit -m "..."

[michaelbrewer]

@heitorlessa maybe there is an alternative solution with the same intent :)

[heitorlessa]

Gotcha, that's what I thought. Sadly there is no alternative, as the pre-commit project decided not to add them as it deems to be a non-safe operation. I was thinking on perhaps removing some of them, but there are higher priority tasks now.

Merging this now ;) Thank you!