-
Notifications
You must be signed in to change notification settings - Fork 425
test(general): Add some missing code coverage #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* test(DictWrapper): Add check for not isinstance * test(tracing): Add mock to test aiohttp_trace_config * test(appconfig): Add test for get_app_config() without a default provider
@cakepietoast some more clean up for the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One clarification and one tiny change - LGTM after that
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #296 +/- ##
===========================================
+ Coverage 99.65% 99.87% +0.21%
===========================================
Files 90 90
Lines 3217 3217
Branches 153 153
===========================================
+ Hits 3206 3213 +7
+ Misses 7 2 -5
+ Partials 4 2 -2
Continue to review full report at Codecov.
|
for the record faf75ca 😈 |
Description of changes:
Checklist