Adding docstring + increasing coverage

aws_lambda_powertools/event_handler/appsync.py

@@ -29,37 +29,135 @@ def context(self):
 
 
 class BaseResolverRegistry(ABC):
+    """
+    Abstract base class for a resolver registry.
+
+    This class defines the interface for managing and retrieving resolvers
+    for various type and field combinations.
+    """
+
     @property
     @abstractmethod
     def resolvers(self) -> Dict[str, Dict[str, Any]]:
-        ...
+        """
+        Get the dictionary of resolvers.
+
+        Returns
+        -------
+        dict
+            A dictionary containing resolver information.
+        """
+        raise NotImplementedError
 
     @resolvers.setter
     @abstractmethod
     def resolvers(self, resolvers: dict) -> None:
-        ...
+        """
+        Set the dictionary of resolvers.
+
+        Parameters
+        ----------
+        resolvers: dict
+            A dictionary containing resolver information.
+        """
+        raise NotImplementedError
 
     @abstractmethod
     def resolver(self, type_name: str = "*", field_name: Optional[str] = None) -> Callable:
-        ...
+        """
+        Retrieve a resolver function for a specific type and field.
+
+        Parameters
+        -----------
+        type_name: str
+            The name of the type.
+        field_name: Optional[str]
+            The name of the field (default is None).
+
+        Returns
+        -------
+        Callable
+            The resolver function.
+        """
+        raise NotImplementedError
 
     @abstractmethod
     def find_resolver(self, type_name: str, field_name: str) -> Optional[Callable]:
-        ...
+        """
+        Find a resolver function for a specific type and field.
+
+        Parameters
+        -----------
+        type_name: str
+            The name of the type.
+        field_name: str
+            The name of the field.
+
+        Returns
+        -------
+        Optional[Callable]
+            The resolver function. None if not found.
+        """
+        raise NotImplementedError
 
 
 class BasePublic(ABC):
+    """
+    Abstract base class for public interface methods for resolver.
+
+    This class outlines the methods that must be implemented by subclasses to manage resolvers and
+    context information.
+    """
+
     @abstractmethod
     def resolver(self, type_name: str = "*", field_name: Optional[str] = None) -> Callable:
-        ...
+        """
+        Retrieve a resolver function for a specific type and field.
+
+        Parameters
+        -----------
+        type_name: str
+            The name of the type.
+        field_name: Optional[str]
+            The name of the field (default is None).
+
+        Returns
+        -------
+        Callable
+            The resolver function.
+        """
+        raise NotImplementedError
 
     @abstractmethod
     def batch_resolver(self, type_name: str = "*", field_name: Optional[str] = None) -> Callable:
-        ...
+        """
+        Retrieve a batch resolver function for a specific type and field.
+
+        Parameters
+        -----------
+        type_name: str
+            The name of the type.
+        field_name: Optional[str]
+            The name of the field (default is None).
+
+        Returns
+        -------
+        Callable
+            The batch resolver function.
+        """
+        raise NotImplementedError
 
     @abstractmethod
     def append_context(self, **additional_context) -> None:
-        ...
+        """
+        Append additional context information.
+
+        Parameters
+        -----------
+        **additional_context: dict
+            Additional context key-value pairs to append.
+        """
+        raise NotImplementedError
 
 
 class ResolverRegistry(BaseResolverRegistry):

tests/functional/event_handler/test_appsync.py

@@ -245,6 +245,49 @@ def get_locations2(name: str):
     assert result2 == "get_locations2#value"
 
 
+def test_resolver_batch_resolver_many_fields_with_different_name():
+    # GIVEN
+    app = AppSyncResolver()
+    router = Router()
+
+    @router.batch_resolver(type_name="Query", field_name="listLocations")
+    def get_locations(event: AppSyncResolverEvent, name: str) -> str:
+        return "get_locations#" + name + "#" + event.source["id"]
+
+    app.include_router(router)
+
+    # WHEN
+    mock_event1 = [
+        {
+            "typeName": "Query",
+            "info": {
+                "fieldName": "listLocations",
+                "parentTypeName": "Query",
+            },
+            "fieldName": "listLocations",
+            "arguments": {"name": "value"},
+            "source": {
+                "id": "1",
+            },
+        },
+        {
+            "typeName": "Query",
+            "info": {
+                "fieldName": "listLocationsDifferente",
+                "parentTypeName": "Query",
+            },
+            "fieldName": "listLocations",
+            "arguments": {"name": "value"},
+            "source": {
+                "id": "1",
+            },
+        },
+    ]
+
+    with pytest.raises(ValueError):
+        app.resolve(mock_event1, LambdaContext())
+
+
 def test_resolver_include_batch_resolver():
     # GIVEN
     app = AppSyncResolver()