fix(logging): Escape double-quotes when serializing strings into JSON. #1845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A (found while working on something else)
Description of changes:
This is a small change fixing an edge case where the JSON formatting of structured arguments in the logging module was broken. If a String contained double quotes they were not escaped leading to a broken JSON output in the Lambda logs.
Example:
Before
Invalid JSON (inner double quotes are not escaped)
jq: parse error: Invalid numeric literal at ...
After
Valid JSON
Checklist