Skip to content

chore(metrics): Fix low hanging fruit for v2 #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Feb 28, 2025

Please provide the issue number

Issue number: #798

Summary

Changes

update TargetFramework to net8.0 and adjust MaxDimensions limit

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig February 28, 2025 14:54
@boring-cyborg boring-cyborg bot added area/common Core Powertools utility area/metrics Core metrics utility documentation Improvements or additions to documentation tests labels Feb 28, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2025
@github-actions github-actions bot added the internal Maintenance changes label Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.04%. Comparing base (0e10c0c) to head (8b6b839).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #800   +/-   ##
========================================
  Coverage    74.04%   74.04%           
========================================
  Files          210      210           
  Lines         8402     8402           
  Branches       910      910           
========================================
  Hits          6221     6221           
  Misses        1883     1883           
  Partials       298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjgraca hjgraca merged commit a61f747 into aws-powertools:develop Feb 28, 2025
9 checks passed
@hjgraca hjgraca deleted the fix/low-hanging-fruit-metrics-v2 branch February 28, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/common Core Powertools utility area/metrics Core metrics utility documentation Improvements or additions to documentation internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants