-
Notifications
You must be signed in to change notification settings - Fork 26
chore: Metrics PushSingleMetric default dimensions #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hjgraca
merged 10 commits into
aws-powertools:develop
from
hjgraca:feature/metrics-single-default-dimensions
Feb 27, 2025
Merged
chore: Metrics PushSingleMetric default dimensions #780
hjgraca
merged 10 commits into
aws-powertools:develop
from
hjgraca:feature/metrics-single-default-dimensions
Feb 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #780 +/- ##
========================================
Coverage 73.95% 73.96%
========================================
Files 210 210
Lines 8378 8381 +3
Branches 904 904
========================================
+ Hits 6196 6199 +3
Misses 1884 1884
Partials 298 298 ☔ View full report in Codecov by Sentry. |
…imensions' into feature/metrics-single-default-dimensions
leandrodamascena
approved these changes
Feb 25, 2025
leandrodamascena
approved these changes
Feb 25, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/metrics
Core metrics utility
documentation
Improvements or additions to documentation
github-actions
Changes in GitHub workflows
internal
Maintenance changes
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #779
Summary
Changes
Add support for
Metrics.DefaultDimensions
property in static Metrics. This makes it easier to reuse DefaultDimensions inPushSingleMetric
.Options.DefaultDimensions
for intances of Metrics when using the Builder or Configuration patterns.User experience
Empty Default dimensions
with new Dictionary<string, string>
Use existing Default Dimensions
Use
Metrics.DefaultDimensions
static propertyOptions or Builder patterns
Use
Options.DefaultDimensions
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.