Skip to content

chore: idempotency e2e tests #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jan 30, 2025

Please provide the issue number

Issue number: #701

Summary

Changes

This pull request includes various changes to the e2e test workflows, solution files, and function constructs to improve the deployment and testing processes. The most important changes include updates to the e2e test workflow, the addition of new projects to the solution file, and the introduction of shared infrastructure constructs.

E2E Test Workflow Updates:

Solution File Updates:

Function Constructs:

Test Utility Updates:

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig January 30, 2025 15:04
@boring-cyborg boring-cyborg bot added github-actions Changes in GitHub workflows internal Maintenance changes tests labels Jan 30, 2025
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (4e154a9) to head (2c1f193).
Report is 19 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #738   +/-   ##
========================================
  Coverage    73.34%   73.34%           
========================================
  Files          201      201           
  Lines         8118     8118           
  Branches       871      871           
========================================
  Hits          5954     5954           
  Misses        1875     1875           
  Partials       289      289           
Flag Coverage Δ
unittests 73.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment: I see that you are using for loop in a lot of tests. I think tests should be deterministic and using for statements it is easy to miss something because you need to test variables/conditions all the time. Also, it is hard to read the test and understand.

But this is just a comment, feel free to merge as is and improve later.

…Created helper methods for executing requests to reduce code duplication.Made the test flow more linear and easier to follow
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 3, 2025
@hjgraca
Copy link
Contributor Author

hjgraca commented Feb 3, 2025

@leandrodamascena thank you for the feedback I updated the pull request.

  • Removed nested for loops and replaced them with explicit test cases
  • Made the test flow more linear and easier to follow
  • Created helper methods for executing requests to reduce code duplication

Copy link

sonarqubecloud bot commented Feb 3, 2025

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the feedback @hjgraca! APPROVED!

@hjgraca hjgraca merged commit bfe6c8c into aws-powertools:develop Feb 3, 2025
10 checks passed
@hjgraca hjgraca deleted the feat(e2e)-idempotency-e2e-tests branch February 3, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Changes in GitHub workflows internal Maintenance changes size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants