-
Notifications
You must be signed in to change notification settings - Fork 26
chore: idempotency e2e tests #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: idempotency e2e tests #738
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #738 +/- ##
========================================
Coverage 73.34% 73.34%
========================================
Files 201 201
Lines 8118 8118
Branches 871 871
========================================
Hits 5954 5954
Misses 1875 1875
Partials 289 289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment: I see that you are using for
loop in a lot of tests. I think tests should be deterministic and using for
statements it is easy to miss something because you need to test variables/conditions all the time. Also, it is hard to read the test and understand.
But this is just a comment, feel free to merge as is and improve later.
…a-dotnet into feat(e2e)-idempotency-e2e-tests
…Created helper methods for executing requests to reduce code duplication.Made the test flow more linear and easier to follow
@leandrodamascena thank you for the feedback I updated the pull request.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the feedback @hjgraca! APPROVED!
Issue number: #701
Summary
Changes
This pull request includes various changes to the e2e test workflows, solution files, and function constructs to improve the deployment and testing processes. The most important changes include updates to the e2e test workflow, the addition of new projects to the solution file, and the introduction of shared infrastructure constructs.
E2E Test Workflow Updates:
.github/workflows/e2e-tests.yml
: Updated to deploy all stacks (--all
flag) and added a matrix strategy for running tests on different utilities [1] [2] [3] [4] [5] [6].Solution File Updates:
libraries/AWS.Lambda.Powertools.sln
: Added new projects forInfraShared
andIdempotency
and removed specific core payload references [1] [2] [3] [4].Function Constructs:
libraries/tests/e2e/InfraShared/FunctionConstruct.cs
: Renamed and updated to include new packaging commands and environment variables.libraries/tests/e2e/InfraShared/FunctionConstructProps.cs
: Added new properties for handling AOT and environment variables.libraries/tests/e2e/InfraShared/IdempotencyStack.cs
: Introduced a new stack for managing idempotency tests.libraries/tests/e2e/InfraShared/InfraShared.csproj
: New project file for shared infrastructure constructs.Test Utility Updates:
libraries/tests/e2e/functions/TestUtils/FunctionConstructProps.cs
: Removed redundant file after merging properties into shared constructs.libraries/tests/e2e/functions/core/logging/Function/test/Function.Tests/FunctionTests.cs
: Updated payload path for function tests.libraries/tests/e2e/functions/core/metrics/Function/test/Function.Tests/FunctionTests.cs
: Enabled ARM AOT metrics test and updated payload path [1] [2].libraries/tests/e2e/functions/core/tracing/Function/test/Function.Tests/FunctionTests.cs
: Enabled ARM AOT tracing test and updated payload path [1] [2].User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.