Skip to content

chore: Fix Service override on decorator #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jan 23, 2025

Please provide the issue number

Issue number: #702

Summary

Changes

Modified the logger provider initialization, adding new test classes and methods, and updating test setups for better organization and functionality.

Logger provider initialization:

Test enhancements:

Test setup improvements:

Minor updates:

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig January 23, 2025 17:06
@boring-cyborg boring-cyborg bot added area/logging Core logging utility tests labels Jan 23, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (dc7180a) to head (5984626).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #704   +/-   ##
========================================
  Coverage    73.34%   73.34%           
========================================
  Files          200      200           
  Lines         8112     8112           
  Branches       871      871           
========================================
  Hits          5950     5950           
  Misses        1874     1874           
  Partials       288      288           
Flag Coverage Δ
unittests 73.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@hjgraca hjgraca merged commit 84765d0 into aws-powertools:develop Jan 27, 2025
9 checks passed
@hjgraca hjgraca deleted the fix(logging)-service-name-override branch January 27, 2025 10:11
@github-actions github-actions bot added the internal Maintenance changes label Jan 27, 2025
@hjgraca hjgraca mentioned this pull request Jan 27, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Core logging utility internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants