Skip to content

Conversation

@hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jun 23, 2023

Please provide the issue number

Issue number: #290

Summary

Docs urls need to be updated to lambda/ so lambda/dotnet instead of lambda-dotnet

Changes

Please provide a summary of what's being changed

update urls to new format. remove latest from .net url

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig June 23, 2023 13:41
@boring-cyborg boring-cyborg bot added area/logging Core logging utility area/metrics Core metrics utility area/parameters area/tracing Core tracing utility documentation Improvements or additions to documentation github-templates Changes in GitHub issue/PR templates internal Maintenance changes labels Jun 23, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.14 🎉

Comparison is base (6a46c4e) 69.08% compared to head (5aa5598) 69.22%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #315      +/-   ##
===========================================
+ Coverage    69.08%   69.22%   +0.14%     
===========================================
  Files           79       79              
  Lines         3448     3448              
===========================================
+ Hits          2382     2387       +5     
+ Misses        1066     1061       -5     
Flag Coverage Δ
unittests 69.22% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hjgraca hjgraca linked an issue Jun 26, 2023 that may be closed by this pull request
1 task
Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
@hjgraca hjgraca merged commit f51155a into develop Jun 26, 2023
@hjgraca hjgraca deleted the url-updates branch June 26, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/logging Core logging utility area/metrics Core metrics utility area/parameters area/tracing Core tracing utility documentation Improvements or additions to documentation github-templates Changes in GitHub issue/PR templates internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: Documentation updates

3 participants