-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EKS Istio Dashboards #194
Conversation
@bonclay7 Can you please review this request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you guys install https://pre-commit.com/ and run pre-commit run -a
?
@bonclay7 sure, this is complete |
thanks let me re-run the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! few minor changes, and we'll be able to ship
Added istioctl prereq, updated dashboards image
Updated Istio Bookinfo sample app instructions, included clean up of Bookinfo resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dms486 thanks for your patience on this. Please address my new comments, run pre-commit and we'll get this merged today
-Switching image to Github generated link -Removing advanced configuration section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a LOT!
What does this PR do?
Adding the EKS Istio dashboards example
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs.
For Moderators
Additional Notes