Add EKS Istio Dashboards #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bonclay7 Can you please review this request? |
bonclay7
reviewed
Jul 20, 2023
There was a problem hiding this comment.
Can you guys install https://pre-commit.com/ and run pre-commit run -a ?
|
@bonclay7 sure, this is complete |
bonclay7
reviewed
Jul 20, 2023
|
thanks let me re-run the tests |
bonclay7
reviewed
Jul 24, 2023
bonclay7
reviewed
Jul 26, 2023
bonclay7
reviewed
Jul 26, 2023
bonclay7
reviewed
Jul 26, 2023
Added istioctl prereq, updated dashboards image
Updated Istio Bookinfo sample app instructions, included clean up of Bookinfo resources
-Switching image to Github generated link -Removing advanced configuration section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding the EKS Istio dashboards example
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted. Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs.
For Moderators
Additional Notes