Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 1.13.0 #355

Merged
merged 3 commits into from
Feb 23, 2023
Merged

chore(release): 1.13.0 #355

merged 3 commits into from
Feb 23, 2023

Conversation

ps863
Copy link
Member

@ps863 ps863 commented Feb 8, 2023

This PR releases 1.13.0

The following changes are made:

Features:

Create a session ID when cookies are disabled, in order to link all events in a single page together(#314) (6943587)

Increase default stack trace length from 200 to 1000(#313) (28e34c5)

Record referrer and referrer's domain (#327) (a414c92)

Record the webclient version and web client installation method (#321) (97c543a)

Record time spent on a page ( (#341)(d1c3b17)

Bug Fixes:

Add type to recordJsErrorEvent parameter (#339) (2ee6ffa)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ps863 ps863 requested review from qhanam and adebayor123 February 8, 2023 17:28
Copy link
Member

@adebayor123 adebayor123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - assuming these features are ready from DP/CP

CHANGELOG.md Outdated

* Create a session ID when cookies are disabled ([#314](https://github.com/aws-observability/aws-rum-web/issues/314)) ([6943587](https://github.com/aws-observability/aws-rum-web/commit/6943587259b8d7623742656199dc26b26b5bcd5d))
* Increase stack trace length ([#313](https://github.com/aws-observability/aws-rum-web/issues/313)) ([28e34c5](https://github.com/aws-observability/aws-rum-web/commit/28e34c5ad541e1fc1e0b12c1a937289df5911791))
* referrer ([#327](https://github.com/aws-observability/aws-rum-web/issues/327)) ([a414c92](https://github.com/aws-observability/aws-rum-web/commit/a414c9265b37f9eafe7ae6475fe71357beadbcfc))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: What this change does isn't clear from the description. Same with lines 13 and 14.

In retrospect, we should catch things like this during code review, as the commit message does not adhere to convention.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@ps863 ps863 merged commit 0150cdc into aws-observability:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants