Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppSignals Functionality - add AlwaysRecordSampler and Utility files, add pr-build workflow #9

Merged
merged 14 commits into from
Aug 2, 2024

Conversation

jj22ee
Copy link
Contributor

@jj22ee jj22ee commented Jul 31, 2024

Issue #, if available:

Description of changes:
Implement the following files in TypeScript

always-record-sampler.ts
aws-attribute-keys.ts
aws-span-processing-util.ts
configuration/sql_dialect_keywords.json
sqs-url-parser.ts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jj22ee jj22ee requested a review from srprash July 31, 2024 18:39
@jj22ee jj22ee requested a review from a team as a code owner July 31, 2024 18:39
Copy link

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the unit tests for these files as you go?

@jj22ee jj22ee changed the title AppSignals Functionality - add AlwaysRecordSampler and Utility files AppSignals Functionality - add AlwaysRecordSampler and Utility files, add pr_build workflow Aug 1, 2024
.github/workflows/pr_build.yml Outdated Show resolved Hide resolved
.github/workflows/pr_build.yml Outdated Show resolved Hide resolved
.github/workflows/pr_build.yml Outdated Show resolved Hide resolved
.github/workflows/pr_build.yml Outdated Show resolved Hide resolved
.markdownlint-cli2.jsonc Outdated Show resolved Hide resolved
@jj22ee jj22ee changed the title AppSignals Functionality - add AlwaysRecordSampler and Utility files, add pr_build workflow AppSignals Functionality - add AlwaysRecordSampler and Utility files, add pr-build workflow Aug 2, 2024
@jj22ee jj22ee merged commit 9aa8086 into main Aug 2, 2024
6 checks passed
@jj22ee jj22ee deleted the record-sampler-and-utilities-pr branch August 2, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants