Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre/post release workflow #22

Merged
merged 3 commits into from
Aug 21, 2024
Merged

add pre/post release workflow #22

merged 3 commits into from
Aug 21, 2024

Conversation

pxaws
Copy link
Member

@pxaws pxaws commented Aug 20, 2024

Issue #, if available:

Description of changes:

Add the pre release and post release workflows.

Manually tested it to make sure it can successfully create the relevant pull requests:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pxaws pxaws requested a review from a team as a code owner August 20, 2024 20:02
@pxaws pxaws force-pushed the setup-release-workflow branch 6 times, most recently from 29f4dfe to 64c7e1a Compare August 20, 2024 21:42
@pxaws pxaws force-pushed the setup-release-workflow branch 3 times, most recently from 5792e3c to f0f84a5 Compare August 21, 2024 16:32
@pxaws pxaws changed the title add pre release workflow add pre/post release workflow Aug 21, 2024
Copy link
Contributor

@jj22ee jj22ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Can we change workflow filenames to use - instead of _ to be consistent with the other workflows in this repo?

.github/workflows/pre_release_prepare.yml Outdated Show resolved Hide resolved
.github/workflows/post_release_version_bump.yml Outdated Show resolved Hide resolved
.github/workflows/post_release_version_bump.yml Outdated Show resolved Hide resolved
.github/workflows/post_release_version_bump.yml Outdated Show resolved Hide resolved
.github/workflows/post_release_version_bump.yml Outdated Show resolved Hide resolved
@pxaws
Copy link
Member Author

pxaws commented Aug 21, 2024

lgtm.

Can we change workflow filenames to use - instead of _ to be consistent with the other workflows in this repo?

Sure, I didn't noticed that we are using a different name from adot python repo: https://github.com/aws-observability/aws-otel-python-instrumentation/tree/main/.github/workflows

@pxaws pxaws force-pushed the setup-release-workflow branch from 59da204 to c7d72fa Compare August 21, 2024 17:25
Copy link
Contributor

@jj22ee jj22ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@pxaws pxaws merged commit c46b0c6 into main Aug 21, 2024
6 checks passed
@pxaws pxaws deleted the setup-release-workflow branch August 21, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants