Add Sample ExpressJS App for testing #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srprash
reviewed
Jul 24, 2024
thpierce
reviewed
Jul 24, 2024
thpierce
approved these changes
Jul 24, 2024
srprash
approved these changes
Jul 24, 2024
jj22ee
added a commit
that referenced
this pull request
Jul 31, 2024
*Issue #, if available:* Includes some commits in: #2 *Description of changes:* 1. Code changes to implement ADOT Layer around OTel JS - The directory, but most importantly the `register.ts` file, is based on [upstream OTel contrib auto-instrumentation package](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/metapackages/auto-instrumentations-node). ``` .gitignore aws-distro-opentelemetry-autoinstrumentation/README.md aws-distro-opentelemetry-autoinstrumentation/package-lock.json aws-distro-opentelemetry-autoinstrumentation/package.json aws-distro-opentelemetry-autoinstrumentation/src/aws-application-signals-config-provider.ts aws-distro-opentelemetry-autoinstrumentation/src/index.ts aws-distro-opentelemetry-autoinstrumentation/src/register.ts ``` 2. Code changes related to linting - Follows similar linting used in upstream OTel Contrib: - [eslint.config.js](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/eslint.config.js), [prettier.config.js](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/prettier.config.js), and [.eslintrc.js](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/metapackages/auto-instrumentations-node/.eslintrc.js) - Prettier is used for formatting, while eslint mainly focuses on style and provides static code analysis ``` aws-distro-opentelemetry-autoinstrumentation/.eslintignore //lists files to ignore linting aws-distro-opentelemetry-autoinstrumentation/.eslintrc.js eslint.config.js prettier.config.js ``` 3. Code changes related to TypeScript settings - These files specifies the files and the compiler options required to compile the ADOT JS project ``` tsconfig.base.json aws-distro-opentelemetry-autoinstrumentation/tsconfig.json ``` By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add Sample ExpressJS server with 3 endpoints:
curl http://localhost:8080/httpcurl http://localhost:8080/rolldicecurl http://localhost:8080/aws-sdk-s3By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.