Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppSignals Functionality - add Application Signals Configuration into ADOT #12

Merged
merged 10 commits into from
Aug 13, 2024
Merged

AppSignals Functionality - add Application Signals Configuration into ADOT #12

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
09d008b
AppSignals Functionality - add App Signals configuration into ADOT
jj22ee Aug 7, 2024
8278380
disable fs instrumentation by default, add TODO comment for mongoose …
jj22ee Aug 8, 2024
a0b5428
specify direct dependencies in package.json, update package-lock.json
jj22ee Aug 8, 2024
8c03157
enhance 'disable-fs' instrumentation comment
jj22ee Aug 8, 2024
7ca6014
Merge branch 'main' into appsignals-configuration-pr
jj22ee Aug 9, 2024
55610c5
Merge branch 'main' into appsignals-configuration-pr
jj22ee Aug 12, 2024
091ca68
address comments
jj22ee Aug 13, 2024
6600792
update copyright comments and related lint
jj22ee Aug 13, 2024
7f393a2
optimize setting exportIntervalMillis
jj22ee Aug 13, 2024
f9832e9
add unit test for setting OTEL_METRIC_EXPORT_INTERVAL
jj22ee Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
optimize setting exportIntervalMillis
  • Loading branch information
@jj22ee
jj22ee committed Aug 13, 2024
commit 7f393a2bf72edd945c4a874829ae9aa6cc725011
9 changes: 2 additions & 7 deletions aws-distro-opentelemetry-node-autoinstrumentation/src/aws-opentelemetry-configurator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,14 +211,9 @@ export class AwsOpentelemetryConfigurator {

diag.info('AWS Application Signals enabled.');

let millis: string | undefined = process.env[METRIC_EXPORT_INTERVAL_CONFIG];
if (millis === undefined) {
millis = DEFAULT_METRIC_EXPORT_INTERVAL_MILLIS.toString();
}

diag.debug(`AWS Application Signals Metrics export interval: ${millis}`);
let exportIntervalMillis: number = Number(process.env[METRIC_EXPORT_INTERVAL_CONFIG]);
diag.debug(`AWS Application Signals Metrics export interval: ${exportIntervalMillis}`);

let exportIntervalMillis: number = Number(millis).valueOf();
if (isNaN(exportIntervalMillis) || exportIntervalMillis.valueOf() > DEFAULT_METRIC_EXPORT_INTERVAL_MILLIS) {
exportIntervalMillis = DEFAULT_METRIC_EXPORT_INTERVAL_MILLIS;

Expand Down
Loading