Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include AWS Resource Detectors by Default #62

Closed
willarmiros opened this issue Oct 22, 2020 · 3 comments
Closed

Include AWS Resource Detectors by Default #62

willarmiros opened this issue Oct 22, 2020 · 3 comments

Comments

@willarmiros
Copy link
Contributor

willarmiros commented Oct 22, 2020

We should modify our vended config.yaml to include the all AWS-specific resource detectors on the collector. #32 is a first attempt at this, but it is still TBD whether we should include the env resource detector. Eventually, we should have detectors for:

  • EC2
  • ECS
  • EKS (Although the k8s detector could potentially suffice)
  • Elastic Beanstalk
  • Lambda
@mxiamxia
Copy link
Member

Hi William, looked the #32 , I think we need to fix the following things before we can merge it into the collector,

  1. Update the integration test package, at lease we need to update our Traces data validator to verify new attributes created by processor are expected.
  2. The new processor is not built in the collector yet, Your CR should include the same change, otherwise, the collector will be failed to start with the new default config file.
    Thanks.

@willarmiros
Copy link
Contributor Author

I closed #32, I think a larger change is going to be necessary based on your comments. We also have not yet added many of the translation capabilities to convert AWS resource attributes to fields in X-Ray segments. I think once open-telemetry/opentelemetry-collector-contrib#1360 is merged along with a corresponding data model translation PR, I'll circle back to this and the integ test changes.

JasonXZLiu pushed a commit to open-o11y/aws-otel-collector that referenced this issue Nov 19, 2020
…ty#62)

* add data generator support for otlp trace and xray trace

* remove debug logs

* remove the unused commented code

* Integrate high load emitter with soaking test

* Integrate soaking test with load generator

* fix some naming issue

* fix some naming issue

* fix the port problem for xray soaking test

* add soaking test cases for otlp and xray data models

* add soaking test cases for otlp and xray data models

* refactor soaking test cases

* remove some unneccessary vars
@pingleig
Copy link
Member

It's already included

"github.com/open-telemetry/opentelemetry-collector-contrib/processor/resourcedetectionprocessor"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants