Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix host requirements combo box checkability on Linux and macOS #590

Conversation

justinsaws
Copy link
Contributor

Fixes: #587

What was the problem/requirement? (What/Why)

The host requirements combo boxes would not work correctly on Linux and Mac. The selection would get unchecked right after clicking the option.

What was the solution? (How)

The extra signal handling was unnecessary and was the cause of the issue. QComboBox can already handle selection logic on its own between the model and view. You only need to mark the item as selectable and it works.

What is the impact of this change?

Control works as intended.

How was this change tested?

See DEVELOPMENT.md for information on running tests.

  • Have you run the unit tests?
    • Yes.
  • Have you run the integration tests?
    • No.
  • Have you made changes to the download or asset_sync modules? If so, then it is highly recommended
    that you ensure that the docker-based unit tests pass.
    • No.

Does this PR introduce new dependencies?

This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.

  • This PR adds one or more new dependency Python packages. I acknowledge I have reviewed the considerations for adding dependencies in DEVELOPMENT.md.
  • This PR does not add any new dependencies.

Is this a breaking change?

No.

Does this change impact security?

  • Does the change need to be threat modeled? For example, does it create or modify files/directories that must only be readable by the process owner?
    • No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@justinsaws justinsaws requested a review from a team as a code owner February 5, 2025 22:48
Signed-off-by: Justin Sawatzky <132946620+justinsaws@users.noreply.github.com>
@justinsaws justinsaws force-pushed the justinsaws/fix_host_requirements branch from e5afdf0 to 39998fa Compare February 5, 2025 22:56
Copy link

sonarqubecloud bot commented Feb 5, 2025

@justinsaws justinsaws enabled auto-merge (squash) February 5, 2025 23:29
@justinsaws justinsaws merged commit c4e6cdc into aws-deadline:mainline Feb 5, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: host requirements dropdowns don't work in macOS
5 participants