feat: support --submitter-name option for bundle GUI submitter command #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Crowe <crowest@amazon.com>
leongdl
previously approved these changes
Jul 25, 2024
epmog
requested changes
Jul 25, 2024
src/deadline/client/ui/dialogs/submit_job_to_deadline_dialog.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephen Crowe <crowest@amazon.com>
leongdl
approved these changes
Aug 1, 2024
|
rena-cheng
pushed a commit
to rena-cheng/deadline-cloud
that referenced
this pull request
Aug 26, 2024
aws-deadline#416) * feat: support --submitter-name option for bundle submitter commands Signed-off-by: Stephen Crowe <crowest@amazon.com> Signed-off-by: Cloud User <rocky@ip-172-31-31-216.ec2.internal>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
One great way of integrating Deadline Cloud into a DCC is adding a button that invokes the GUI bundle submitter. To improve the UX, we can allow the submitter name (currently always "JobBundle" for bundle GUI submissions) to be customized. The submitter name is used for some alerts (e.g. an alert title "JobBundle job submission") and for bundle directory names in the job history folder.
What was the solution? (How)
Add a new
--submitter-nameoption.What is the impact of this change?
A process that submits a job using the GUI bundle submitter appears more like a "real submitter" in the UI and job history folder.
How was this change tested?
Unit tests. Also manual tests:
Was this change documented?
Documented in the CLI help automatically.
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.